Skip to content

Add tests for file and stream downloads #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EnricoMi merged 8 commits into from
Feb 14, 2025
Merged

Add tests for file and stream downloads #3182

EnricoMi merged 8 commits into from
Feb 14, 2025

Conversation

@EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Jan 30, 2025 •
edited
Loading

Extends the test framework to test streaming responses. Adds test for GitReleaseAsset downloads.

Follow-up on #3060

@EnricoMi EnricoMi force-pushed the stream-download-tests branch 2 times, most recently from 4e1b9bd to d7f084c Compare January 30, 2025 20:37
@EnricoMi EnricoMi mentioned this pull request Jan 30, 2025
Merged
@EnricoMi EnricoMi force-pushed the stream-download-tests branch from 12a686f to e55879f Compare January 30, 2025 20:57
@EnricoMi EnricoMi force-pushed the stream-download-tests branch from e55879f to d4ba83f Compare January 30, 2025 21:00
@EnricoMi EnricoMi merged commit d483fe2 into main Feb 14, 2025
14 checks passed
@EnricoMi EnricoMi deleted the stream-download-tests branch February 14, 2025 15:27
@EnricoMi EnricoMi added the maintenance General maintenance not adding features or fixes label Feb 15, 2025
@EnricoMi EnricoMi mentioned this pull request Aug 8, 2025
Merged
EnricoMi added a commit that referenced this pull request Aug 25, 2025
@EnricoMi @lpbedard
Rework redirection URL allowance check (#3329)
065b131 
Cleans redirection URL check that got extended in the wrong way by #3182.

Supersedes (and includes for contribution attribution) #3300. Fixes #3315.

---------

Co-authored-by: Louis-Philippe Bedard <lpbedard@coveo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance General maintenance not adding features or fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EnricoMi