Add has_discussions to AuthenticatedUser and Repository classes#3020
Merged
EnricoMi merged 4 commits intoPyGithub:mainfrom Aug 26, 2024
Merged
Add has_discussions to AuthenticatedUser and Repository classes#3020EnricoMi merged 4 commits intoPyGithub:mainfrom
has_discussions to AuthenticatedUser and Repository classes#3020EnricoMi merged 4 commits intoPyGithub:mainfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
========================================
Coverage 96.73% 96.73%
========================================
Files 149 150 +1
Lines 15061 15254 +193
========================================
+ Hits 14569 14756 +187
- Misses 492 498 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Author
|
Sorry for the messy set of commits. I finally checked out the repo and ran the tests locally to figure out what was going wrong with the testing Replay misses. |
Contributor
|
If this is approved and merged in, then close out mine at the same time: #2781 |
has_discussions to AuthenticatedUser and Repository classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
has_discussionsfeature is exposed in the Github API and is identical in the way it works to something likehas_wiki. Following a couple previous PR attempts by @amnuts and @heitorPB as well as the existing code forhas_wikiI addedhas_discussionsas well as the test cases.Fixes #2733 and #2994