Skip to content

Adds has_discussions property to Repo#2781

Closed
amnuts wants to merge 5 commits intoPyGithub:mainfrom
amnuts:issue-2733/has-discussions
Closed

Adds has_discussions property to Repo#2781
amnuts wants to merge 5 commits intoPyGithub:mainfrom
amnuts:issue-2733/has-discussions

Conversation

@amnuts
Copy link
Copy Markdown
Contributor

@amnuts amnuts commented Oct 3, 2023

This PR adds the has_discussions property as well as the ability to set it when the auth'd user is creating a new repo.

Fixes #2733.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e584a90) 96.74% compared to head (559b4f4) 96.72%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2781      +/-   ##
==========================================
- Coverage   96.74%   96.72%   -0.02%     
==========================================
  Files         139      139              
  Lines       14184    14193       +9     
==========================================
+ Hits        13722    13728       +6     
- Misses        462      465       +3     
Files Coverage Δ
github/AuthenticatedUser.py 96.22% <100.00%> (+<0.01%) ⬆️
github/GithubRetry.py 93.81% <100.00%> (ø)
github/RepositoryAdvisory.py 93.39% <ø> (ø)
github/Auth.py 95.73% <75.00%> (-0.38%) ⬇️
github/Repository.py 93.46% <71.42%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amnuts amnuts changed the title Issue 2733/has discussions Adds has discussions property - fixed #2733 Oct 25, 2023
@EnricoMi EnricoMi changed the title Adds has discussions property - fixed #2733 Adds has discussions property Aug 26, 2024
@EnricoMi EnricoMi changed the title Adds has discussions property Adds has discussions property to Repo Aug 26, 2024
@EnricoMi EnricoMi changed the title Adds has discussions property to Repo Adds has_discussions property to Repo Aug 26, 2024
Copy link
Copy Markdown
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi
Copy link
Copy Markdown
Collaborator

Merging #3020 in favour of this one as it includes tests.

@EnricoMi EnricoMi closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Add support for repo.has_discussions

3 participants