Skip to content

Add has_discussions field to Repository class#2995

Merged
EnricoMi merged 4 commits intoPyGithub:mainfrom
heitorPB:add-has-discussions
Jul 29, 2024
Merged

Add has_discussions field to Repository class#2995
EnricoMi merged 4 commits intoPyGithub:mainfrom
heitorPB:add-has-discussions

Conversation

@heitorPB
Copy link
Copy Markdown
Contributor

Add property and configuration of GitHub discussions per repository.

Fix #2994

heitorPB added 3 commits June 21, 2024 11:16
Add property and configuration of GitHub discussions per repository.
@heitorPB
Copy link
Copy Markdown
Contributor Author

heitorPB commented Jun 21, 2024

I don't know what's going on with the CI...

Copy link
Copy Markdown
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi enabled auto-merge July 29, 2024 18:10
@EnricoMi EnricoMi added this pull request to the merge queue Jul 29, 2024
Merged via the queue into PyGithub:main with commit 7213cd0 Jul 29, 2024
EnricoMi added a commit that referenced this pull request Jul 29, 2024
@EnricoMi
Copy link
Copy Markdown
Collaborator

Looks like this PR is incomplete.

@heitorPB
Copy link
Copy Markdown
Contributor Author

What's missing @EnricoMi ?

@EnricoMi
Copy link
Copy Markdown
Collaborator

This PR is inconsistent, it adds has_properties attribute but tests has_discussions.

@heitorPB
Copy link
Copy Markdown
Contributor Author

Ouch, my multitasking skills are so bad I mixed stuff around.

What do you suggest as a followup?

@heitorPB
Copy link
Copy Markdown
Contributor Author

Btw, the issue should be re-opened, right?

@EnricoMi
Copy link
Copy Markdown
Collaborator

What do you suggest as a followup?

Undelete your branch, fix the branch and create a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure repository discussions

2 participants