Skip to content

Add created and check_suite_id filter for Repository Workflow runs#2891

Merged
EnricoMi merged 6 commits intoPyGithub:mainfrom
treee111:enhance-workflow
Mar 14, 2024
Merged

Add created and check_suite_id filter for Repository Workflow runs#2891
EnricoMi merged 6 commits intoPyGithub:mainfrom
treee111:enhance-workflow

Conversation

@treee111
Copy link
Copy Markdown
Contributor

@treee111 treee111 commented Feb 1, 2024 •
edited
Loading

This PR

This PR adds created and check_suite_id filter, which allows filtering for workflow runs created within the given date-time range and a given Workflow via ID.
For more information on the syntax, see "Understanding the search syntax." API Docs here.

Example usage:

  1. Filtering for workflow runs by created on a repository level (all workflows):
g = Github("access_token")
g.get_repo("PyGithub/PyGithub").get_workflow_runs(created="2022-12-24")
  1. Filtering for workflow runs by created for a specific workflow
g = Github("access_token")
workflow = g.get_repo("PyGithub/PyGithub").get_workflow("ci.yml")
workflow.get_runs(created="2022-12-24")

superseds #2389

@treee111
Copy link
Copy Markdown
Contributor Author

treee111 commented Feb 1, 2024

@RuneStone0 @msaperst @joshuataylor could you please test if this still works for you!
I rebased onto main and added the second field.

@treee111 treee111 force-pushed the enhance-workflow branch 2 times, most recently from 29b020d to 623e1a8 Compare February 1, 2024 12:13
@msaperst
Copy link
Copy Markdown

msaperst commented Feb 1, 2024

@RuneStone0 @msaperst @joshuataylor could you please test if this still works for you! I rebased onto main and added the second field.

This works for me

msaperst
msaperst approved these changes Feb 1, 2024
View reviewed changes
Copy link
Copy Markdown

@msaperst msaperst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

EnricoMi
EnricoMi approved these changes Mar 14, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.71%. Comparing base (0b8435f) to head (ddcc493).

Files Patch % Lines
github/Repository.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2891   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         147      147           
  Lines       14877    14883    +6     
=======================================
+ Hits        14388    14394    +6     
  Misses        489      489

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EnricoMi EnricoMi mentioned this pull request Mar 14, 2024
Closed
@EnricoMi EnricoMi merged commit c788985 into PyGithub:main Mar 14, 2024
@treee111 treee111 deleted the enhance-workflow branch April 19, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EnricoMi EnricoMi EnricoMi approved these changes

+1 more reviewer

@msaperst msaperst msaperst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@treee111 @msaperst @codecov-commenter @EnricoMi @joshuataylor