Add "created" filter for Repository Workflow runs#2389
Add "created" filter for Repository Workflow runs#2389joshuataylor wants to merge 1 commit intoPyGithub:mainfrom
Conversation
| branch: Union[Branch, _NotSetType] = ..., | ||
| event: Union[str, _NotSetType] = ..., | ||
| status: Union[str, _NotSetType] = ..., | ||
| created: Union[datetime, _NotSetType] = ..., |
There was a problem hiding this comment.
Should this be Union[str, _NotSetType] ? since the parameter created is a string as mentioned in GitHub Docs
https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#list-workflow-runs-for-a-repository
There was a problem hiding this comment.
I think we can use str or datetime, if using datetime, we can convert it to str internally
Also need to keep pyi synced with py.
|
As mentioned here, there are multiple missing fields on the get_workflow_runs() method. I think this would be a great opportunity to add the following missing params:
|
|
You can set I agree that |
|
@joshuataylor @akumar1-godaddy @AnderUstarroz who volunteers continuing this pull request? |
|
Sorry for the delay, the last few months have been crazy here. I'll take a look a this PR and hopefully polish it up this week. :) |
|
@joshuataylor any updates on pushing this to main? I tested the code and it works great. |
|
any updates on this fix? |
|
This is open to the community to pick up and continue. Above comments are still valid and not yet addressed. |
|
Closed in favour of #2891. |
This
createdfilter, which allows filtering for workflow runs created within the given date-time range. For more information on the syntax, see "Understanding the search syntax." API Docs here.Example usage:
FYI -
check.ymldoesn't exist anymore in the repository, the tests should be changed toci.yml.