-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add make_latest to GitRelease.update_release
#2888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2888 +/- ##
==========================================
- Coverage 96.74% 96.73% -0.02%
==========================================
Files 147 147
Lines 14978 14984 +6
==========================================
+ Hits 14491 14495 +4
- Misses 487 489 +2 ☔ View full report in Codecov by Sentry. |
- assert separated from post_parameters - asserts and post_parameter sections sorted like order of arguments in the method signature
|
This would be really useful for me, any hope of having it merged? |
EnricoMi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
When can this be released? |
…and_release (#3067) ### The problem: def "create_git_release" and "create_git_tag_and_release" can not create releases that are not the "latest", as by default they are set as "latest" ### How solving the problem: adding optional parameter "make_latest", from original api doc: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release similar to: #2888
…and_release (PyGithub#3067) ### The problem: def "create_git_release" and "create_git_tag_and_release" can not create releases that are not the "latest", as by default they are set as "latest" ### How solving the problem: adding optional parameter "make_latest", from original api doc: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release similar to: PyGithub#2888
…and_release (PyGithub#3067) ### The problem: def "create_git_release" and "create_git_tag_and_release" can not create releases that are not the "latest", as by default they are set as "latest" ### How solving the problem: adding optional parameter "make_latest", from original api doc: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release similar to: PyGithub#2888
…and_release (PyGithub#3067) ### The problem: def "create_git_release" and "create_git_tag_and_release" can not create releases that are not the "latest", as by default they are set as "latest" ### How solving the problem: adding optional parameter "make_latest", from original api doc: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release similar to: PyGithub#2888
The problem:
How solving the problem:
additions
discussion_category_namehas been addedsuperseds #2788