Skip to content

Conversation

@treee111
Copy link
Contributor

The problem:

  • def "update_release" can not make release as "latest"

How solving the problem:

additions

  • documentation URL has changed
  • discussion_category_name has been added

superseds #2788

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.73%. Comparing base (7266e81) to head (965f497).

❗ Current head 965f497 differs from pull request most recent head 843da76. Consider uploading reports for the commit 843da76 to get more accurate results

Files Patch % Lines
github/GitRelease.py 77.77% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   96.74%   96.73%   -0.02%     
==========================================
  Files         147      147              
  Lines       14978    14984       +6     
==========================================
+ Hits        14491    14495       +4     
- Misses        487      489       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- assert separated from post_parameters
- asserts and post_parameter sections sorted like order of arguments in the method signature
@treee111 treee111 requested a review from EnricoMi February 5, 2024 13:04
@jantmanAtCox
Copy link

This would be really useful for me, any hope of having it merged?

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi added this pull request to the merge queue Apr 19, 2024
Merged via the queue into PyGithub:main with commit 6013610 Apr 19, 2024
@treee111 treee111 deleted the make-latest branch April 19, 2024 06:38
@jmaixl
Copy link

jmaixl commented Jul 12, 2024

When can this be released?

github-merge-queue bot pushed a commit that referenced this pull request Dec 15, 2024
…and_release (#3067)

### The problem:

def "create_git_release" and "create_git_tag_and_release" can not create
releases that are not the "latest", as by default they are set as
"latest"

### How solving the problem:

adding optional parameter "make_latest", from original api doc:
https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

similar to: #2888
billnapier pushed a commit to billnapier/PyGithub that referenced this pull request Dec 18, 2024
…and_release (PyGithub#3067)

### The problem:

def "create_git_release" and "create_git_tag_and_release" can not create
releases that are not the "latest", as by default they are set as
"latest"

### How solving the problem:

adding optional parameter "make_latest", from original api doc:
https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

similar to: PyGithub#2888
billnapier pushed a commit to billnapier/PyGithub that referenced this pull request Dec 18, 2024
…and_release (PyGithub#3067)

### The problem:

def "create_git_release" and "create_git_tag_and_release" can not create
releases that are not the "latest", as by default they are set as
"latest"

### How solving the problem:

adding optional parameter "make_latest", from original api doc:
https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

similar to: PyGithub#2888
billnapier pushed a commit to billnapier/PyGithub that referenced this pull request Dec 19, 2024
…and_release (PyGithub#3067)

### The problem:

def "create_git_release" and "create_git_tag_and_release" can not create
releases that are not the "latest", as by default they are set as
"latest"

### How solving the problem:

adding optional parameter "make_latest", from original api doc:
https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

similar to: PyGithub#2888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants