Manually fixing paths for codecov.io to cover all project files#1813
Merged
s-t-e-v-e-n-k merged 3 commits intoPyGithub:masterfrom Mar 8, 2021
Merged
Manually fixing paths for codecov.io to cover all project files#1813s-t-e-v-e-n-k merged 3 commits intoPyGithub:masterfrom
s-t-e-v-e-n-k merged 3 commits intoPyGithub:masterfrom
Conversation
Contributor
Author
|
This PR aims to fix #1812. Feel free to apply or to address this to codecov.io to have them fix the automatic path fixing... |
Codecov Report
@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
+ Coverage 98.76% 98.89% +0.12%
==========================================
Files 51 107 +56
Lines 2677 10992 +8315
==========================================
+ Hits 2644 10870 +8226
- Misses 33 122 +89
Continue to review full report at Codecov.
|
Contributor
Author
|
Note all files are reported unchanged in the code coverage comment, but the number of covered files increases from 51 to 107. |
5 tasks
Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
Contributor
Author
|
@s-t-e-v-e-n-k , sure - reworked the comment(s) as per your suggestion... |
karsten-wagner
added a commit
to karsten-wagner/PyGithub
that referenced
this pull request
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix will change the codecov.io configuration to replace automatic path handling with manual fixes. This is needed to properly reflect all project files in the codecov.io report, since with automatic path fixes it is covering only roughly 50% of the code (compare number of files in the project and those reflected on codecov.io).