Skip to content

Remove older MainClass.get_installation() #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
s-t-e-v-e-n-k merged 1 commit into from
Nov 11, 2020
Merged

Remove older MainClass.get_installation() #1738

s-t-e-v-e-n-k merged 1 commit into from
Nov 11, 2020

Conversation

@s-t-e-v-e-n-k
Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k commented Nov 4, 2020

There are two get_installation() methods in MainClass, with different
arguments. get_installation(owner, repo) is documented and tested, and
get_installation(id) is neither. Remove it to avoid confusion.

@s-t-e-v-e-n-k
Remove older MainClass.get_installation()
8e9ef87 
There are two get_installation() methods in MainClass, with different
arguments. get_installation(owner, repo) is documented and tested, and
get_installation(id) is neither. Remove it to avoid confusion.
@s-t-e-v-e-n-k s-t-e-v-e-n-k mentioned this pull request Nov 4, 2020
Closed
@pascal-hofmann pascal-hofmann self-requested a review November 11, 2020 06:20
pascal-hofmann
pascal-hofmann approved these changes Nov 11, 2020
View reviewed changes
Copy link
Collaborator

@pascal-hofmann pascal-hofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we document the removal?

@s-t-e-v-e-n-k
Copy link
Collaborator Author

s-t-e-v-e-n-k commented Nov 11, 2020

I will do so in the changelog when I make a release.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 19e46bb into PyGithub:master Nov 11, 2020
@atodorov atodorov mentioned this pull request Dec 8, 2020
Closed
atodorov added a commit to kiwitcms/github-app that referenced this pull request Dec 8, 2020
@atodorov
Replace removed Github.get_installation()
dfce3e5 
removed in PyGithub/PyGithub#1738
@atodorov atodorov mentioned this pull request Dec 8, 2020
Merged
atodorov added a commit to kiwitcms/github-app that referenced this pull request Dec 8, 2020
@atodorov
Replace removed Github.get_installation()
2476476 
removed in PyGithub/PyGithub#1738
atodorov added a commit to kiwitcms/github-app that referenced this pull request Dec 8, 2020
@atodorov
Replace removed Github.get_installation()
f66d4dd 
removed in PyGithub/PyGithub#1738
@jainankit jainankit mentioned this pull request Dec 30, 2020
Closed
@s-t-e-v-e-n-k s-t-e-v-e-n-k deleted the remove-older-get-installation branch October 21, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pascal-hofmann pascal-hofmann pascal-hofmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s-t-e-v-e-n-k @pascal-hofmann