Implement hash for CompletableGithubObject (#1922)

s-t-e-v-e-n-k · web-flow · commit 4faff23ce9ea · 2021-04-26T14:24:00.000+10:00
Since CompletableGithubObject already uses its URL attribute to implement equality, extend it to also use that attribute for hashing. Fixes #1826
diff --git a/github/GithubObject.py b/github/GithubObject.py
@@ -286,6 +286,9 @@ def __init__(self, requester, headers, attributes, completed):
     def __eq__(self, other):
         return other.__class__ is self.__class__ and other._url.value == self._url.value
 
+    def __hash__(self):
+        return hash(self._url.value)
+
     def __ne__(self, other):
         return not self == other
 
diff --git a/tests/Equality.py b/tests/Equality.py
@@ -30,16 +30,14 @@ class Equality(Framework.TestCase):
     def testUserEquality(self):
         u1 = self.g.get_user("jacquev6")
         u2 = self.g.get_user("jacquev6")
-        self.assertTrue(u1 == u2)
-        self.assertFalse(u1 != u2)
         self.assertEqual(u1, u2)
+        self.assertEqual(hash(u1), hash(u2))
 
     def testUserDifference(self):
         u1 = self.g.get_user("jacquev6")
         u2 = self.g.get_user("OddBloke")
-        self.assertFalse(u1 == u2)
-        self.assertTrue(u1 != u2)
         self.assertNotEqual(u1, u2)
+        self.assertNotEqual(hash(u1), hash(u2))
 
     def testBranchEquality(self):
         # Erf, equality of NonCompletableGithubObjects will be difficult to implement
