Implement hash for CompletableGithubObject#1922
Merged
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom Apr 26, 2021
Merged
Implement hash for CompletableGithubObject#1922s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom
Conversation
Since CompletableGithubObject already uses its URL attribute to implement equality, extend it to also use that attribute for hashing. Fixes PyGithub#1826
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
=========================================
Coverage ? 98.85%
=========================================
Files ? 108
Lines ? 11062
Branches ? 0
=========================================
Hits ? 10935
Misses ? 127
Partials ? 0 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since CompletableGithubObject already uses its URL attribute to
implement equality, extend it to also use that attribute for hashing.
Fixes #1826