Skip to content

Add Changelog, docs and tests to source tarball#1266

Merged
timothycrosley merged 1 commit intoPyCQA:developfrom
sebix:include-data-test-docs
Jul 6, 2020
Merged

Add Changelog, docs and tests to source tarball#1266
timothycrosley merged 1 commit intoPyCQA:developfrom
sebix:include-data-test-docs

Conversation

@sebix
Copy link
Copy Markdown
Contributor

@sebix sebix commented Jul 5, 2020

Same as #531 which does no longer work, as now
poetry seems to be used for building the packages

Same as PyCQA#531 which does no longer work, as now
poetry seems to be used for building the packages
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1266 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop     #1266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2133      2133           
=========================================
  Hits          2133      2133           

@timothycrosley
Copy link
Copy Markdown
Member

Thank you!

@timothycrosley timothycrosley merged commit a87efea into PyCQA:develop Jul 6, 2020
@timothycrosley
Copy link
Copy Markdown
Member

@sebix unfourtantely, I had to revert this. It looks like adding extra files is not quite as straight forward with poetry as I would have assumed. See: #1285. Which I confirmed locally, all the included files ended up just littering the root of my sitepackages. I couldn't easily figure out a good way around it, and the state of the issues on Poetry's issue tracker around it didn't give me much hope

@sebix
Copy link
Copy Markdown
Contributor Author

sebix commented Jul 8, 2020

@sebix unfourtantely, I had to revert this. It looks like adding extra files is not quite as straight forward with poetry as I would have assumed. See: #1285. Which I confirmed locally, all the included files ended up just littering the root of my sitepackages. I couldn't easily figure out a good way around it, and the state of the issues on Poetry's issue tracker around it didn't give me much hope

Ok, too bad that this is not - easily - possible with poetry. The files should have just ended up in the sdist tarball. Sorry for the inconvenience.

@timothycrosley
Copy link
Copy Markdown
Member

No problem at all! I appreciate you drawing my attention to the issue! I've reopened #463

sebix pushed a commit to sebix/isort that referenced this pull request Jul 12, 2020
@sebix
Copy link
Copy Markdown
Contributor Author

sebix commented Jul 12, 2020

Adding python files (tests) in sdist only is possible -> https://python-poetry.org/docs/pyproject/#packages and #1313
Adding static files (docs) in sdist is currently not possible -> python-poetry/poetry#1338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants