Updated Windows compatibilty patches#979
Updated Windows compatibilty patches#979alex85k wants to merge 11 commits intoProject-OSRM:masterfrom
Conversation
|
@alex85k thanks for the updated patch set. Much appreciated! Do you think we should rename the UUID(C) class to give it a better and more telling name? |
|
I am not very good at naming classes, just tried to make the smallest possible change. :) |
|
Right, let me meditate a bit on class names. Now, I got to setup the Windows build slave for our Jenkins CI instance. |
|
Oh, I forgot the updated instructions and batch files: https://gist.github.com/alex85k/8637217#file-a_readme-md |
|
@alex85k quick question before I dive into it: Did all the tests pass on Windows? |
|
Yes, the tests did pass correctly (checked before adding 0624f33 on VS2013 build). Will run recheck to be sure (will post results tomorrow). |
|
@alex85k awesome. thanks |
|
I forgot to add - 127.0.0.1 on newer Windows could be much faster than localhost (IPV6 setup problems). The tests finished, 8 are failing :( cucumber features\options\files.feature:19 # Scenario: Passing base file I guess it is because special color-realted symbols are printed on console. |
|
Another sample: |
|
When running manually, I get Maybe ←[0m is the problem? |
|
hm, ok. that's coming from SimpleLogger. I'll look into that. it shouldn't be too hard to fix. |
…fixes Windows woes. See #979
|
The commit above should help with the failing tests. @alex85k Can you run them again and report on the status? |
|
Thank you, the tests are passing after using fixed develop as base brach and pathcing options.rb (adding .exe and quote marks). (I rebased to develop branch and did git push --force. Hope it will work on Github) |
|
Gem install bundle failed on Travis. It is not me :) |
|
looks like it's just a network problem on travis: |
|
Let me just restart the thing. |
|
@alex85k passing now. |
|
Good! If any further testing is needed, let me know. |
|
Thanks. Will do |
|
@alex85k very good! I'm really in troubles trying to compile OSRM for Windows. Do you have some "place" with the binaries ? Tks |
|
@rfrezino : We are waiting for Windows build server and official builds) |
|
@alex85k Ok, tks again. I'll keep following your project, it's going to be very useful. |
|
So, here is the plan to get this into mainline:
|
|
After spending a day trying to follow the Windows Compilation guide - with no success in the end - I stumbled upon this. So am I understanding correctly that the guide is outdated, and official builds are going to pop up very soon? I'd like to be able to debug the code. |
|
@calinseciu Strange, I had updated the guide recently (see also discssion in https://gist.github.com/alex85k/8637217#file-a_readme-md |
|
@alex85k oh I was not aware of this guide. Although no debugging, it should be great to be able to finally compile the project. I'll give it one more try, thanks. |
|
It can be compile it as debug too (just use debug version of Boost and replace CMAKE_BUILD_TYPE in scripts). |
…fixes Windows woes. See #979
|
Let me know when the rebased patch is needed :) |
|
anytime ;) |
|
Great, can you rebase on develop? |
|
I did rebase them to develop but pushed them to this pull-request for master. Should I create new PR? One single test is failing on Windows: features/testbot/oneway.feature ( Tables were not identical (Cucumber::Ast::Table::Different) ). I have no idea why. |
|
You should be able to just change the target branch. |
|
As stackoverflow says, I can't :) |
|
Alright then lets close here. |
I have updated Windows compatibility code from
#880
to simplify futher integration.
#646
Many problematic places (like asm code) were already fixed in develop branch, only "big" fixes that remains are UUID renaming, path.c_str() -> path.string().c_str() replacement and xsi shared memory alternative. Tests pass on Windows correctly (when cuke_datastore is not included).