fix: sol2 header to allow for empty lua macro definitions#7441
Merged
DennisOSRM merged 5 commits intoProject-OSRM:masterfrom Mar 31, 2026
Merged
fix: sol2 header to allow for empty lua macro definitions#7441DennisOSRM merged 5 commits intoProject-OSRM:masterfrom
DennisOSRM merged 5 commits intoProject-OSRM:masterfrom
Conversation
Contributor
Author
|
needed a master merge for auto-merge to work, can you try again @DennisOSRM? thanks! |
Collaborator
|
Let's wait for CI to complete. Once the PR is approved it should merge automatically |
DennisOSRM
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
based on #7440 (about to be merged I guess)
found by opus: seems that the macros
LUA_COMPAT_BITLIB&LUA_COMPAT_5_2are not always properly defined with a value.so this PR lets sol2 tolerate empty macros.
Tasklist