fix: make osrm FetchContent compatible#7440
Merged
DennisOSRM merged 2 commits intoProject-OSRM:masterfrom Mar 30, 2026
Merged
Conversation
…fter installing packages
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
claude opus 4.6 made these changes. of course reviewed by me;) they make sense.
conan_toolchain.cmake, also change its order to come after installing the packages, which is the process providing the info actually going into that fileincluderather thansetfor the toolchain file, which will immediately set all important paths for cmake. it works in upstream osrm bcs it's happening in the same cmake project. if used in parent projects cmake config is already done by the time it tries tosetthe toolchain file, so it's too late and nothing would change.Tasklist
Fixes #7439