Skip to content

fix: make osrm FetchContent compatible#7440

Merged
DennisOSRM merged 2 commits intoProject-OSRM:masterfrom
nilsnolde:nn-cmake-fixes
Mar 30, 2026
Merged

fix: make osrm FetchContent compatible#7440
DennisOSRM merged 2 commits intoProject-OSRM:masterfrom
nilsnolde:nn-cmake-fixes

Conversation

@nilsnolde
Copy link
Copy Markdown
Contributor

@nilsnolde nilsnolde commented Mar 30, 2026

Issue

claude opus 4.6 made these changes. of course reviewed by me;) they make sense.

  • make the conan installation path explicit, i.e. where it looks for the conanfile.py
  • same for the path to conan_toolchain.cmake, also change its order to come after installing the packages, which is the process providing the info actually going into that file
  • use include rather than set for the toolchain file, which will immediately set all important paths for cmake. it works in upstream osrm bcs it's happening in the same cmake project. if used in parent projects cmake config is already done by the time it tries to set the toolchain file, so it's too late and nothing would change.

Tasklist

Fixes #7439

Copy link
Copy Markdown
Collaborator

@DennisOSRM DennisOSRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@DennisOSRM DennisOSRM merged commit 9000f51 into Project-OSRM:master Mar 30, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't install OSRM with FetchContent

2 participants