Move #ifdef OSRM_HAS_STD_FORMAT from call sites into format.hpp#7371
Merged
DennisOSRM merged 2 commits intocopilot/replace-boost-format-with-libfmtfrom Feb 19, 2026
Merged
Conversation
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move ifdef into format.hpp for better organization
Move Feb 19, 2026
#ifdef OSRM_HAS_STD_FORMAT from call sites into format.hpp
Collaborator
|
@copilot make sure the change is formatted as needed. |
Contributor
Author
Confirmed — ran |
DennisOSRM
approved these changes
Feb 19, 2026
a255dc0
into
copilot/replace-boost-format-with-libfmt
1 check passed
DennisOSRM
added a commit
that referenced
this pull request
Feb 21, 2026
* Initial plan * Replace boost::format with libfmt across the codebase Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Remove unnecessary util/log.hpp include from shared_monitor.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix code formatting as reported by CI Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix npm audit security vulnerability in tar package Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <memory> include to multi_level_partition.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <memory> include to compressed_edge_container.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <vector> include to io_config.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <string> and <cstring> includes to storage headers Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing includes: util/format.hpp and <vector> Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix runtime format string handling for C++20 std::format compatibility Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * [WIP] Fix build errors in project (#7367) * Fix clang-format-18 formatting in include/util/format.hpp (#7368) * Fix std::make_format_args rvalue binding error with GCC 13 (#7369) * Fix missing `<unistd.h>` include for macOS in io-benchmark (#7370) * Move `#ifdef OSRM_HAS_STD_FORMAT` from call sites into `format.hpp` (#7371) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> Co-authored-by: Dennis Luxen <info@project-osrm.org>
MarcelloPerathoner
pushed a commit
to MarcelloPerathoner/osrm-backend
that referenced
this pull request
Feb 24, 2026
* Initial plan * Replace boost::format with libfmt across the codebase Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Remove unnecessary util/log.hpp include from shared_monitor.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix code formatting as reported by CI Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix npm audit security vulnerability in tar package Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <memory> include to multi_level_partition.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <memory> include to compressed_edge_container.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <vector> include to io_config.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing <string> and <cstring> includes to storage headers Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Add missing includes: util/format.hpp and <vector> Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix runtime format string handling for C++20 std::format compatibility Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * [WIP] Fix build errors in project (Project-OSRM#7367) * Fix clang-format-18 formatting in include/util/format.hpp (Project-OSRM#7368) * Fix std::make_format_args rvalue binding error with GCC 13 (Project-OSRM#7369) * Fix missing `<unistd.h>` include for macOS in io-benchmark (Project-OSRM#7370) * Move `#ifdef OSRM_HAS_STD_FORMAT` from call sites into `format.hpp` (Project-OSRM#7371) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> Co-authored-by: Dennis Luxen <info@project-osrm.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call sites in
utils.hppandtable_service.cpphad duplicated#ifdef OSRM_HAS_STD_FORMATguards to select betweenruntime_format(std) andruntime(fmt). The compatibility abstraction should live entirely informat.hpp.Changes
include/util/format.hpp— Addruntime_formatto thefmtfallback branch, wrappingfmt::runtime, so both branches expose a uniformruntime_formatinterface:include/server/service/utils.hpp/src/server/service/table_service.cpp— Remove#ifdef OSRM_HAS_STD_FORMATguards at call sites; both now unconditionally callosrm::util::compat::runtime_format(msg_template).Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.