Add configurable max_collapse_distance property to Lua profiles for p…#7344
Merged
TheMarex merged 5 commits intoProject-OSRM:masterfrom Jan 27, 2026
Merged
Conversation
|
Nice! Looks good! |
TheMarex
reviewed
Jan 27, 2026
Member
TheMarex
left a comment
There was a problem hiding this comment.
Thanks for salvaging the previous PR! I've added a few recommendations and you may have missed one of the constants?
b8fe669 to
46769e1
Compare
TheMarex
approved these changes
Jan 27, 2026
|
super great thanks! |
MarcelloPerathoner
pushed a commit
to MarcelloPerathoner/osrm-backend
that referenced
this pull request
Feb 24, 2026
Project-OSRM#7344) * Add configurable max_collapse_distance property to Lua profiles for pedestrian routing * Add log entry * Fix format * Remove defaults, move init to constructor, pass max_collapse_distance * Add missing GetMaxCollapseDistance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6171
max_collapse_distanceproperty toProfileProperties(default: 30.0m)GetMaxCollapseDistance()to DataFacade interfaceTasklist
Requirements / Relations
Supersedes #7252