Add regression tests for zero-speed segment updates#7341
Add regression tests for zero-speed segment updates#7341DennisOSRM merged 6 commits intoProject-OSRM:masterfrom
Conversation
f0eddec to
748ec17
Compare
There was a problem hiding this comment.
Pull request overview
Fixes incorrect routing/turn behavior when closing segments via --segment-speed-file during MLD customization, attributed to concurrent turn-penalty updates.
Changes:
- Add mutex-based synchronization around a turn-penalty write during parallel edge updates in the updater.
- Add Cucumber scenarios covering “closure shouldn’t cascade” routing regressions.
- Add an Unreleased changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/updater/updater.cpp | Introduces mutex/lock guard around a turn_weight_penalties update during tbb::parallel_for. |
| features/testbot/zero-speed-updates.feature | Adds regression scenarios to ensure closures don’t block turns at unrelated intersections or cascade to parallel routes. |
| CHANGELOG.md | Adds an Unreleased entry describing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi, I misunderstood how I have updated the PR title and description and feel free to close if not useful. |
fb424df to
4c14513
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4c14513 to
f0ab011
Compare
f0ab011 to
9f9654a
Compare
Issue
Add Cucumber scenarios to verify that closing segments via
--segment-speed-filedoesn't incorrectly block turns at unrelated intersections or cascade to parallel routes.Also add a unit test documenting the turn_id uniqueness invariant and improves the turn penalty warning log.
Tasklist
Requirements / Relations
Related to #7332