support highway="trunk" for foot and bicycle in some countries#6703
Closed
tombay wants to merge 0 commit intoProject-OSRM:masterfrom
tombay:tombay-trunk-allowed
Closed
support highway="trunk" for foot and bicycle in some countries#6703tombay wants to merge 0 commit intoProject-OSRM:masterfrom tombay:tombay-trunk-allowed
tombay wants to merge 0 commit intoProject-OSRM:masterfrom
tombay:tombay-trunk-allowed
Conversation
tombay
commented
Sep 21, 2023
tombay
commented
Sep 21, 2023
tombay
commented
Sep 21, 2023
tombay
commented
Sep 21, 2023
tombay
commented
Sep 21, 2023
frodrigo
reviewed
Nov 24, 2023
| destination.lua | Function for finding relevant destination tags | ||
| maxspeed.lua | Function for determining maximum speed | ||
| guidance.lua | Function for processing guidance attributes | ||
| local_trunks.lua |Function to check trunk roads for access based on country |
Member
There was a problem hiding this comment.
Suggested change
| local_trunks.lua |Function to check trunk roads for access based on country | |
| local_trunks.lua | Function to check trunk roads for access based on country |
Author
There was a problem hiding this comment.
Hi frodrigo.
I assume the issue is PR #6708 (which resolves PR #6697). I commented on #6697 on 4 Oct while I was working on my issue. I included my changes in my resolution. The issue #6703 (or #6710) addresses the issue where bicycle (and foot) access is allowed on highway="trunk" in some countries.
If #6708 is added the set of countries is reduced. (docs/profiles.md line 400 in this PR).
If #6708 is to be added to Project-OSRM:master I will move this back to draft and then reopen when it is added.
Ciao
Tom
Member
There was a problem hiding this comment.
@systemed What do you think of this change request and two PR ?
frodrigo
reviewed
Nov 24, 2023
| ``` | ||
| 'BEL', 'CHL', 'DEU', 'FIN', 'FRA', 'GRC', 'GBR', 'HRV', 'NLD', 'RUS'. | ||
| ``` | ||
| [if the changes in bicycle.lua are are included this comment can be removed] |
Member
There was a problem hiding this comment.
Suggested change
| [if the changes in bicycle.lua are are included this comment can be removed] | |
| [if the changes in bicycle.lua are included this comment can be removed] |
Member
|
It looks like to me the PR now content unrelated changes. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
An issue #6710 has been logged (reopening #6701).
Address the issue of highway=trunk (and trunk_link) being blocked for foot and bicycle profiles. Discussed in https://wiki.openstreetmap.org/wiki/Key:motorroad and https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access_restrictions (esp #Alternative_ideas) proposed to address issue via
osrm-backend ... --location-dependent-data trunk-allowed.geojson.
The 30 countries allowing trunk access are include in the polyline data.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?