updated turn restriction tests#159
Merged
DennisOSRM merged 1 commit intoProject-OSRM:masterfrom Mar 2, 2012
Merged
Conversation
…uring tests. add tests for no-right-turn
This was referenced Mar 2, 2012
DennisOSRM
pushed a commit
that referenced
this pull request
Mar 2, 2012
updated turn restriction tests
Collaborator
|
Most of the failing tests of turn restrictions fail, because the route makes a u-turn at some dead-end street. Using U-turns there is standard modeling of a road network and is not a bug per se. I looked at the modeled situations of the tests and although they are technically sound, these situations do not occur in reality. I my opinion the tests should use one-way streets at the possible turns to prohibit any U-turning. OSRM does not really distinguish between the directions of the turns. All that is checked, is if it has the 'only_' or the 'no_' prefix. The rest is redundant information and thus discarded. |
Contributor
Author
|
good idea to use oneways. i will update the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cucumber tests now loads the correct .osrm.restrictions file.
i also updated all the restrictions tests (there were a few bugs in the previous markup), and added tests for no_right_turn, no_u_turn, only_left_turn and only_right_turn.
most test now pass (yay!), but i did find a few things: