Skip to content

Task/FOUR-20032-fall: Hide FlowGenie from Ellucian's servers#7706

Merged
ryancooley merged 2 commits intorelease-2025-winterfrom
task/FOUR-20032-fall
Jan 23, 2025
Merged

Task/FOUR-20032-fall: Hide FlowGenie from Ellucian's servers#7706
ryancooley merged 2 commits intorelease-2025-winterfrom
task/FOUR-20032-fall

Conversation

@agustinbusso
Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso commented Nov 7, 2024

Issue & Reproduction Steps

This PR implements https://processmaker.atlassian.net/browse/FOUR-20032

Related PRs

@boliviacoca boliviacoca added 4.13.0 and removed 4.12.0 labels Jan 8, 2025
@agustinbusso agustinbusso changed the base branch from release-2024-fall to release-2025-winter January 10, 2025 18:05
@agustinbusso
Copy link
Copy Markdown
Contributor Author

There are some failing tests, and it seems that are not related to the changes in this PR:

SAMLLogout (ProcessMaker\Package\Auth\Tests\Feature\SAMLLogout)
 ✘ Logout saml
   │
   │ Failed asserting that two strings are equal.
   │ --- Expected
   │ +++ Actual
   │ @@ @@
   │ -'https://localhost/login'
   │ +'https://localhost/requests'
   │
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:311
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Testing/TestResponse.php:178
   │ /opt/packages/package-auth/tests/Feature/Auth/SAMLLogoutTest.php:106
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176
   │
Formula (Tests\PackageDecisionEngine\Feature\Formula)
 ✘ Decision table with correct values
   │
   │ Error: Call to undefined method Tests\PackageDecisionEngine\Feature\FormulaTest::createProcessFromJSON()
   │
   │ /opt/packages/package-decision-engine/tests/feature/FormulaTest.php:20
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176
   │

 ✘ Decision table with incorrect values
   │
   │ Error: Call to undefined method Tests\PackageDecisionEngine\Feature\FormulaTest::createProcessFromJSON()
   │
   │ /opt/packages/package-decision-engine/tests/feature/FormulaTest.php:55
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176
   │

 ✘ Decision table without values
   │
   │ Error: Call to undefined method Tests\PackageDecisionEngine\Feature\FormulaTest::createProcessFromJSON()
   │
   │ /opt/packages/package-decision-engine/tests/feature/FormulaTest.php:90
   │ /opt/processmaker/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:176
   │

CC @ryancooley

@ryancooley ryancooley merged commit 104ba3b into release-2025-winter Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants