Merged
Conversation
|
eiresendez
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0.0% Coverage on New Code
0.0% Duplication on New Code
This PR resolves a failing 'ScriptExecutorTest'. The error occurred due to the admin user now being set as the default run_script_as_user when importing scripts. The solution was to update the tests to ensure an admin user was created in the database as well as asserting the run_script_as_user matched that of the admin user.
How to Test
phpunit tests/Feature/ImportExport/Exporters/ScriptExecutorTest.php.ci:next
Code Review Checklist