Skip to content

Fix failing 'ScriptExecutorsTest' #6215

Merged
ryancooley merged 2 commits intonextfrom
fix-failing-script-executor-test
Feb 14, 2024
Merged

Fix failing 'ScriptExecutorsTest' #6215
ryancooley merged 2 commits intonextfrom
fix-failing-script-executor-test

Conversation

@sanjacornelius
Copy link
Copy Markdown
Contributor

This PR resolves a failing 'ScriptExecutorTest'. The error occurred due to the admin user now being set as the default run_script_as_user when importing scripts. The solution was to update the tests to ensure an admin user was created in the database as well as asserting the run_script_as_user matched that of the admin user.

How to Test

  1. Run the test phpunit tests/Feature/ImportExport/Exporters/ScriptExecutorTest.php.
  2. Ensure all tests pass without errors.

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@sanjacornelius sanjacornelius changed the title Fix failing 'ScriptExecutorsTest' by Updating Tests for Default Run Script As User Fix failing 'ScriptExecutorsTest' Feb 13, 2024
@processmaker-sonarqube
Copy link
Copy Markdown

@eiresendez eiresendez self-requested a review February 13, 2024 21:08
@ryancooley ryancooley merged commit 263190b into next Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants