Skip to content

FOUR-12245 customize SAML library used for the idp#5767

Merged
caleeli merged 6 commits intofeature/FOUR-11375from
feature/FOUR-12245
Dec 6, 2023
Merged

FOUR-12245 customize SAML library used for the idp#5767
caleeli merged 6 commits intofeature/FOUR-11375from
feature/FOUR-12245

Conversation

@devmiguelangel
Copy link
Copy Markdown
Contributor

@devmiguelangel devmiguelangel commented Dec 5, 2023 •
edited by atlassian bot
Loading

Solution

  • Customize the metadata for the SAML library

Related Tickets & Packages

FOUR-12245

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next
ci:SAML_SP_DESTINATION=https://keycloak.processmaker.net/realms/pm4-next/broker/pm4-saml/endpoint

@tokensPM
Copy link
Copy Markdown

tokensPM commented Dec 5, 2023

QA server was successfully deployed https://ci-e142f18c80.eng.processmaker.net

julceslauhub
julceslauhub reviewed Dec 5, 2023
View reviewed changes
resources/views/vendor/samlidp/metadata.blade.php Outdated
@@ -0,0 +1,21 @@
@php echo '<?xml version="1.0"?>' @endphp
<md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata" validUntil="2027-01-20T19:04:25Z" cacheDuration="PT1485371065S" entityID="{{ url(config('samlidp.issuer_uri')) }}">
Copy link
Copy Markdown
Contributor

@julceslauhub julceslauhub Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions: What are the "validUntil" and "cacheDuration" values based on when they are generated? Can't current "hardcoded" values be generated in the code?

Copy link
Copy Markdown
Contributor Author

@devmiguelangel devmiguelangel Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These variables mean

  • validUntil the expiration time of the metadata
  • cacheDuration the maximum period of time a consumer should cache the metadata

I added some functions to generate them dynamically

@processmaker-sonarqube
Copy link
Copy Markdown

processmaker-sonarqube bot commented Dec 6, 2023

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@tokensPM
Copy link
Copy Markdown

tokensPM commented Dec 6, 2023

QA server was successfully deployed https://ci-e142f18c80.eng.processmaker.net

julceslauhub
julceslauhub approved these changes Dec 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@caleeli caleeli merged commit 08de871 into feature/FOUR-11375 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julceslauhub julceslauhub julceslauhub approved these changes

@caleeli caleeli caleeli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devmiguelangel @tokensPM @julceslauhub @caleeli