Improve get activated transition in gateway#5708
Merged
ryancooley merged 2 commits intodevelopfrom Nov 29, 2023
Merged
Conversation
nolanpro
reviewed
Nov 28, 2023
| return; | ||
| } | ||
| $transition = $gateway->getTransitions()[$transaction['transition']] ?? null; | ||
| if (empty($transaction)) { |
Contributor
There was a problem hiding this comment.
@caleeli should this be empty($transition) instead of empty($transaction)?
nolanpro
approved these changes
Nov 28, 2023
boliviacoca
approved these changes
Nov 29, 2023
c133306 to
cae5383
Compare
|
SonarQube Quality Gate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Fix way to send the reference to Gateway Transition was triggered or passed. This is used for comments.
Related tickets
Code Review Checklist