Skip to content

Improve get activated transition in gateway#5708

Merged
ryancooley merged 2 commits intodevelopfrom
bugfix/gateway_comments
Nov 29, 2023
Merged

Improve get activated transition in gateway#5708
ryancooley merged 2 commits intodevelopfrom
bugfix/gateway_comments

Conversation

@caleeli
Copy link
Copy Markdown
Contributor

@caleeli caleeli commented Nov 28, 2023

Fix way to send the reference to Gateway Transition was triggered or passed. This is used for comments.

  • This code use the transition index to reference the outgoing chosen by a gateway instead of the ID.

Related tickets

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

return;
}
$transition = $gateway->getTransitions()[$transaction['transition']] ?? null;
if (empty($transaction)) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caleeli should this be empty($transition) instead of empty($transaction)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nolanpro nolanpro self-requested a review November 28, 2023 18:04
@ryancooley ryancooley force-pushed the bugfix/gateway_comments branch from c133306 to cae5383 Compare November 29, 2023 22:31
@processmaker-sonarqube
Copy link
Copy Markdown

@ryancooley ryancooley merged commit 1887fa1 into develop Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants