NSIS: Update Regex for constants pattern#3267
Merged
RunDevelopment merged 2 commits intoPrismJS:masterfrom Dec 4, 2021
idleberg:fix/nsis-defines-pattern
Merged
NSIS: Update Regex for constants pattern#3267RunDevelopment merged 2 commits intoPrismJS:masterfrom idleberg:fix/nsis-defines-pattern
RunDevelopment merged 2 commits intoPrismJS:masterfrom
idleberg:fix/nsis-defines-pattern
Conversation
RunDevelopment
approved these changes
Dec 4, 2021
Member
|
Thank you for contributing @idleberg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #3266, the constant patterns needs to be updated to support
!-characters. While this is, arguably, highly unreadable, it's valid code shown in this example (take note of the line${!defineifexist} var_name file_name).Changes: