Skip to content

NSIS: Update Regex pattern for variables#3266

Merged
RunDevelopment merged 7 commits intoPrismJS:masterfrom
idleberg:master
Dec 4, 2021
Merged

NSIS: Update Regex pattern for variables#3266
RunDevelopment merged 7 commits intoPrismJS:masterfrom
idleberg:master

Conversation

@idleberg
Copy link
Copy Markdown
Contributor

@idleberg idleberg commented Dec 4, 2021

Unless at the beginning of a variable name, variables in NSIS may contain the .-character (see example).

Changes:

  • update Regex pattern for variables to support dots
  • add test for the above

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 4, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +4 B (+0.2%).

Details
file master pull size diff % diff
components/prism-nsis.min.js 2.02 KB 2.02 KB +4 B +0.2%

Generated by 🚫 dangerJS against b352154

Copy link
Copy Markdown
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @idleberg!

@RunDevelopment
Copy link
Copy Markdown
Member

Please also resolve the merge conflict.

@RunDevelopment RunDevelopment merged commit adcc878 into PrismJS:master Dec 4, 2021
@RunDevelopment
Copy link
Copy Markdown
Member

Thank you for contributing @idleberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants