Bash: Add PHP dependency manager composer as a command#2298
Merged
RunDevelopment merged 2 commits intoPrismJS:masterfrom Apr 9, 2020
Ayesh:feature/bash-composer
Merged
Bash: Add PHP dependency manager composer as a command#2298RunDevelopment merged 2 commits intoPrismJS:masterfrom Ayesh:feature/bash-composer
composer as a command#2298RunDevelopment merged 2 commits intoPrismJS:masterfrom
Ayesh:feature/bash-composer
Conversation
RunDevelopment
requested changes
Apr 9, 2020
Member
RunDevelopment
left a comment
There was a problem hiding this comment.
Please also add "composer" to the function test.
RunDevelopment
approved these changes
Apr 9, 2020
Member
|
Thank you for contributing @Ayesh! |
Contributor
Author
|
Thank you @RunDevelopment. I'm sorry I forgot to update the tests. |
Contributor
Author
|
Awesome, this is merged, thank you 🙏. |
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
This adds PHP's dependency manager `composer` to the list of commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
composeris PHP's dependency manager, and I would like to propose that we add it as a command to bash language support. I see thatnpmis already in the list, which has equal grounds ascomposer.Thank you.