Skip to content

Mark flaky Update-Help web tests as pending to unblock CI#26796

Merged
TravisEz13 merged 4 commits intomasterfrom
copilot/fix-update-help-tests
Feb 13, 2026
Merged

Mark flaky Update-Help web tests as pending to unblock CI#26796
TravisEz13 merged 4 commits intomasterfrom
copilot/fix-update-help-tests

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

Update-Help tests downloading from the web have intermittent network failures (timeouts, task cancellations) blocking CI builds. Issues #2807 and #6541 document the pattern.

Changes

  • Mark web-dependent CI tests as pending using Set-ItResult -Pending in RunUpdateHelpTests

    • Only affects tests downloading from the web (not -SourcePath variants using local assets)
    • Only affects CI-tagged tests (Feature-tagged tests remain active)
  • Add defensive null checks for $moduleHelpPath, $saveHelpFolder, $TestDrive to handle Pester discovery phase gracefully

  • Document Set-ItResult pattern in .github/instructions/pester-set-itresult-pattern.instructions.md

    • Pending vs Skipped usage
    • Importance of return after Set-ItResult
    • Examples from codebase

Pattern

It "Validate Update-Help for module $moduleName" {
    if ($markAsPending) {
        Set-ItResult -Pending -Because "Update-Help from the web has intermittent connectivity issues. See issues #2807 and #6541."
        return  # Required to prevent continued execution
    }
    
    Update-Help -Module $moduleName -Force
    # validation...
}

Result

33 of 38 tests now marked as NotRun (pending), unblocking CI while keeping tests visible for future resolution.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits February 12, 2026 21:46
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix or mark update-help tests as pending Mark flaky Update-Help web tests as pending to unblock CI Feb 12, 2026
Copilot AI requested a review from TravisEz13 February 12, 2026 21:56
@TravisEz13 TravisEz13 marked this pull request as ready for review February 12, 2026 21:56
@TravisEz13 TravisEz13 requested a review from a team as a code owner February 12, 2026 21:56
Copilot AI review requested due to automatic review settings February 12, 2026 21:56
@TravisEz13 TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Feb 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses intermittent network failures in Update-Help tests that have been blocking CI builds, as documented in issues #2807 and #6541. The solution marks web-dependent CI tests as pending while preserving Feature-tagged tests and tests using local assets.

Changes:

  • Adds a markAsPending parameter to RunUpdateHelpTests that conditionally marks tests as pending using Set-ItResult
  • Implements defensive null checks for $moduleHelpPath, $saveHelpFolder, and $TestDrive to handle Pester discovery phase gracefully
  • Creates comprehensive instruction documentation for the Set-ItResult pattern to guide future test development

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 Adds markAsPending parameter to selectively mark CI web tests as pending; adds defensive null checks for variables used during Pester discovery phase
.github/instructions/pester-set-itresult-pattern.instructions.md New instruction document explaining when and how to use Set-ItResult for pending/skipped tests, with emphasis on the importance of using return after Set-ItResult

@TravisEz13 TravisEz13 enabled auto-merge (squash) February 12, 2026 22:24
@TravisEz13 TravisEz13 merged commit 6b8d724 into master Feb 13, 2026
54 of 59 checks passed
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Feb 13, 2026
…#26796)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Feb 15, 2026
…#26796)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Feb 17, 2026
…#26796)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Feb 17, 2026
…#26796)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Migrated Backport-7.5.x-Migrated Backport-7.6.x-Migrated CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants