Add ability to capture MSBuild Binary logs when restore fails#24128
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Aug 9, 2024
Merged
Add ability to capture MSBuild Binary logs when restore fails#24128TravisEz13 merged 2 commits intoPowerShell:masterfrom
TravisEz13 merged 2 commits intoPowerShell:masterfrom
Conversation
TravisEz13
commented
Aug 8, 2024
adityapatwardhan
approved these changes
Aug 8, 2024
Contributor
|
📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
…hell#24128) * Capture binary logs * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Oct 11, 2024
…hell#24128) * Capture binary logs * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
adityapatwardhan
pushed a commit
that referenced
this pull request
Oct 11, 2024
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Oct 16, 2024
…hell#24128) * Capture binary logs * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
adityapatwardhan
added a commit
that referenced
this pull request
Oct 16, 2024
TravisEz13
added a commit
that referenced
this pull request
Jan 16, 2025
* Capture binary logs * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
TravisEz13
added a commit
that referenced
this pull request
Jan 16, 2025
#24799) * Capture binary logs * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces changes to enable MSBuild binary logging and improve the handling of build artifacts in the pipeline configuration and build scripts.
Pipeline Configuration Changes:
.pipelines/PowerShell-Coordinated_Packages-Official.yml: Added a new parameterENABLE_MSBUILD_BINLOGSto enable or disable MSBuild binary logs..pipelines/PowerShell-Coordinated_Packages-Official.yml: Updatedvariablessection to include the newENABLE_MSBUILD_BINLOGSparameter.Build Script Enhancements:
build.psm1: Modified theRestore-PSPackagefunction to append the-blargument for binary logging ifENABLE_MSBUILD_BINLOGSis set.build.psm1: Enhanced theRestore-PSPackagefunction to handle and upload MSBuild binary logs if a restore operation fails andENABLE_MSBUILD_BINLOGSis enabled.PR Context
Binary logs are much more readable but are too big to use all the time.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).