Increase timeout to make subsystem tests more reliable#18380
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Oct 25, 2022
Merged
Increase timeout to make subsystem tests more reliable#18380daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
SteveL-MSFT
approved these changes
Oct 25, 2022
|
🎉 Handy links: |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Increase timeout to make subsystem tests more reliable.
PR Context
The
CommandPredictionxUnit tests have been failing for the last 2 days because the expected operation cannot finish before the timeout. The expected operation is done via tasks using the thread pool. xUnit itself generates a lot of tasks backed by thread pool, which makes the task run unpredictable comparing with the real scenario.The old timeout has been working well until very recently (2 days ago), and it may be caused by changes in the CI agent or activities involved in the CI pipeline.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.