Skip to content

Bump to .NET 7 RC2 official version#18328

Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan:bumpRC2
Oct 19, 2022
Merged

Bump to .NET 7 RC2 official version#18328
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan:bumpRC2

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Oct 19, 2022

PR Summary

Bump to the official version of .NET 7 RC2.

PR Context

PR Checklist

@iSazonov iSazonov closed this Oct 19, 2022
@iSazonov iSazonov reopened this Oct 19, 2022
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Oct 19, 2022

This PR has 20 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +16 -4
Percentile : 8%

Total files changed: 2

Change summary by file extension:
.wxs : +15 -3
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Oct 19, 2022

Reopen PR to restart CIs.

@adityapatwardhan adityapatwardhan merged commit 65d3786 into PowerShell:master Oct 19, 2022
@adityapatwardhan adityapatwardhan deleted the bumpRC2 branch October 19, 2022 17:18
@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Oct 25, 2022

/backport to release/v7.3.0-rc.1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2022

@adityapatwardhan backporting to release/v7.3.0-rc.1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Bump to .NET 7 RC2 official version
Using index info to reconstruct a base tree...
M	assets/wix/files.wxs
M	global.json
Falling back to patching base and 3-way merge...
Auto-merging global.json
CONFLICT (content): Merge conflict in global.json
Auto-merging assets/wix/files.wxs
CONFLICT (content): Merge conflict in assets/wix/files.wxs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump to .NET 7 RC2 official version
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Oct 25, 2022

/backport to release/v7.3.0-rc.1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2022

@adityapatwardhan backporting to release/v7.3.0-rc.1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Bump to .NET 7 RC2 official version
Using index info to reconstruct a base tree...
M	assets/wix/files.wxs
M	global.json
Falling back to patching base and 3-way merge...
Auto-merging global.json
CONFLICT (content): Merge conflict in global.json
Auto-merging assets/wix/files.wxs
CONFLICT (content): Merge conflict in assets/wix/files.wxs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump to .NET 7 RC2 official version
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 25, 2022
@adityapatwardhan
Bump to .NET 7 RC2 official version (PowerShell#18328)
bfdf768
@adityapatwardhan adityapatwardhan mentioned this pull request Oct 25, 2022
Merged
22 tasks
adityapatwardhan added a commit that referenced this pull request Oct 25, 2022
@adityapatwardhan
[release/v7.3.0-rc.1] Bump to .NET 7 RC2 official version (#18328) (#…
b6ed99d 
…18377)
@ghost
Copy link
Copy Markdown

ghost commented Oct 26, 2022

🎉v7.3.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 20, 2022
@ghost
Copy link
Copy Markdown

ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

No one assigned

Labels

Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adityapatwardhan @iSazonov