Remove the ProcessorArchitecture portion from the full name as it's obsolete#18320
Remove the ProcessorArchitecture portion from the full name as it's obsolete#18320daxian-dbw merged 2 commits intoPowerShell:masterfrom
ProcessorArchitecture portion from the full name as it's obsolete#18320Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Should we clean up all code base? I see 13 files with |
|
I didn't think that far. This PR is an attempt to resolve the CI test failures in #18286, but it seems not sufficient to make those tests work. |
|
Clear. We could do the cleanup in follow PR(s). |
|
I have verified that this change will fix the test failures in #18286. Will merge this one and rebase the other. |
|
/backport to release/v7.3.0-rc.1 |
|
🎉 Handy links: |
PR Summary
Remove the
ProcessorArchitectureportion from the full name as it's obsolete in .NET 7.0https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assemblyname.processorarchitecture?view=net-7.0
This additional field in the assembly full name started to fail
Assembly.Loadin PowerShell remoting scenario, when starting a remote session. See example failures in the following CI run:https://dev.azure.com/powershell/PowerShell/_build/results?buildId=110951&view=logs&j=8ff999f7-4a61-5f51-a6a7-d94e9758120c&t=b9d6b495-b227-54e1-c647-304a73968aa2&l=396
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.