Skip to content

Remove the ProcessorArchitecture portion from the full name as it's obsolete#18320

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw:arch
Oct 18, 2022
Merged

Remove the ProcessorArchitecture portion from the full name as it's obsolete#18320
daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw:arch

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw commented Oct 18, 2022

PR Summary

Remove the ProcessorArchitecture portion from the full name as it's obsolete in .NET 7.0
https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assemblyname.processorarchitecture?view=net-7.0

This additional field in the assembly full name started to fail Assembly.Load in PowerShell remoting scenario, when starting a remote session. See example failures in the following CI run:
https://dev.azure.com/powershell/PowerShell/_build/results?buildId=110951&view=logs&j=8ff999f7-4a61-5f51-a6a7-d94e9758120c&t=b9d6b495-b227-54e1-c647-304a73968aa2&l=396

PR Checklist

@ghost ghost assigned TravisEz13 Oct 18, 2022
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 18, 2022
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 41 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +19 -22
Percentile : 16.4%

Total files changed: 2

Change summary by file extension:
.cs : +19 -22

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov
Copy link
Copy Markdown
Collaborator

Should we clean up all code base? I see 13 files with ProcessorArchitecture. Ex., we could hide the parameter in cmdlet.

@daxian-dbw
Copy link
Copy Markdown
Member Author

I didn't think that far. This PR is an attempt to resolve the CI test failures in #18286, but it seems not sufficient to make those tests work.

@iSazonov
Copy link
Copy Markdown
Collaborator

Clear. We could do the cleanup in follow PR(s).

@daxian-dbw
Copy link
Copy Markdown
Member Author

I have verified that this change will fix the test failures in #18286. Will merge this one and rebase the other.

@adityapatwardhan
Copy link
Copy Markdown
Member

/backport to release/v7.3.0-rc.1

@ghost
Copy link
Copy Markdown

ghost commented Oct 26, 2022

🎉v7.3.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.3.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants