Do not cleanup pwsh.deps.json for framework dependent packages#18226
Do not cleanup pwsh.deps.json for framework dependent packages#18226adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
/backport to release/v7.3.0-rc.1 |
This comment was marked as outdated.
This comment was marked as outdated.
|
dependent on #18297 |
|
/backport to release/v7.3.0-rc.1 |
|
🎉 Handy links: |
|
Back-port to 7.2 done in #19719 |
PR Summary
When we build fxdependent packages, the native dependencies of
penimc_cor3.dllandmicrosoft.diasymreader.native.amd64.dlldo not exist in the publish folder. This PR exists the logic before attempting a cleanup.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).