Skip to content

On Unix, only explicitly terminate the native process if not in background#18215

Merged
iSazonov merged 8 commits intoPowerShell:masterfrom
SteveL-MSFT:unix-shellexecute
Oct 7, 2022
Merged

On Unix, only explicitly terminate the native process if not in background#18215
iSazonov merged 8 commits intoPowerShell:masterfrom
SteveL-MSFT:unix-shellexecute

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Oct 4, 2022 •
edited
Loading

PR Summary

A change was introduced in 7.2-preview.6 to explicitly terminate unix processes so they weren't orphaned, however, it killed all processes including ones that should be running in the background. The fix is to check to make sure the process isn't in the background before performing the cleanup.

PR Context

Fix #18181

PR Checklist

@ghost ghost assigned TravisEz13 Oct 4, 2022
@SteveL-MSFT SteveL-MSFT changed the title On Unix, only explicit terminate the native process if not in background On Unix, only explicitly terminate the native process if not in background Oct 4, 2022
dkaszews
dkaszews reviewed Oct 4, 2022
View reviewed changes
@SteveL-MSFT @dkaszews
Update src/System.Management.Automation/engine/NativeCommandProcessor.cs
2cd2cd5 
Co-authored-by: Dominik Kaszewski <dakaszewski@gmail.com>
SteveL-MSFT and others added 2 commits October 4, 2022 08:04
daxian-dbw
daxian-dbw reviewed Oct 4, 2022
View reviewed changes
daxian-dbw
daxian-dbw reviewed Oct 6, 2022
View reviewed changes
daxian-dbw
daxian-dbw approved these changes Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

@SteveL-MSFT @daxian-dbw
Update src/System.Management.Automation/engine/NativeCommandProcessor.cs
908a44c 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Oct 6, 2022

This PR has 15 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +8 -7
Percentile : 6%

Total files changed: 1

Change summary by file extension:
.cs : +8 -7

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Oct 7, 2022
@iSazonov iSazonov merged commit 667e755 into PowerShell:master Oct 7, 2022
@SteveL-MSFT SteveL-MSFT deleted the unix-shellexecute branch October 8, 2022 03:14
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Oct 13, 2022

/backport to release/v7.2.7

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Oct 13, 2022

/backport to release/v7.3.0-rc.1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 13, 2022

@TravisEz13 backporting to release/v7.2.7 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: On Unix, only explicit terminate the native process if not in background
Using index info to reconstruct a base tree...
M	src/System.Management.Automation/engine/NativeCommandProcessor.cs
Falling back to patching base and 3-way merge...
Auto-merging src/System.Management.Automation/engine/NativeCommandProcessor.cs
CONFLICT (content): Merge conflict in src/System.Management.Automation/engine/NativeCommandProcessor.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 On Unix, only explicit terminate the native process if not in background
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions github-actions bot mentioned this pull request Oct 13, 2022
Merged
1 task
@TravisEz13 TravisEz13 mentioned this pull request Oct 13, 2022
Merged
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Oct 13, 2022
@SteveL-MSFT @TravisEz13
On Unix, only explicitly terminate the native process if not in backg…
af590ea 
…round (PowerShell#18215)
@ghost
Copy link
Copy Markdown

ghost commented Oct 26, 2022

🎉v7.3.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 26, 2022
Closed
5 tasks
@adityapatwardhan adityapatwardhan added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@dkaszews dkaszews dkaszews approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

macOS: opening documents by file path only is broken

6 participants

@SteveL-MSFT @TravisEz13 @daxian-dbw @iSazonov @dkaszews @adityapatwardhan