Fix legacy $ErrorView types to use $host.PrivateData colors#17705
Fix legacy $ErrorView types to use $host.PrivateData colors#17705daxian-dbw merged 1 commit intoPowerShell:masterfrom
$ErrorView types to use $host.PrivateData colors#17705Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
/backport to release/v7.2.6 |
|
Started backporting to release/v7.2.6: https://github.com/PowerShell/PowerShell/actions/runs/2784906265
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
@loxia01 Please open new issue. |

PR Summary
The change to add
ConciseViewfor$ErrorViewinadvertently removed the coloring for legacy views. The fix is whenConciseViewisn't used, then get the foreground and background colors from the legacy location and set it before outputting the error.PR Context
Fix #16665
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).