This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@MartinGC94, can you please take a quick look at this PR and see if there could be any unwanted side effects after adding || lastAst is ArrayLiteralAst in the check?

The code doesn't work. Get-Command -Type Alias,<Tab> -All fails inside the ProcessParameter method because wordToComplete is null. The test the OP made adds a space between the comma and the cursor so it doesn't actually test the code change he made (which is why the test succeeds).

@MartinGC94 Thanks for catching it! Just tried and found that Get-Command -Type Alias, <Tab> -All doesn't work too as of today, so I guess the change fixed that but not -Type Alias,<tab> -All?

No this PR doesn't seem to fix anything. Get-Command -Type Alias, <Tab> -All doesn't work because no code was changed to fix it from its current broken state. -Type Alias,<tab> -All doesn't work because of the previously mentioned null exception further down the method chain.

@daxian-dbw @MartinGC94 Thank you for your reply and I am sorry for my mistake. I have tested it again.

It works for the following commands:

• Get-ChildItem -Path .\a.txt,<TAB> -Recurse
• Get-Alias -Name gal,<TAB> -Verbose
• Get-Module -Name PSReadLine,<TAB> -All

But it does not work, as you say, for Get-Command -Type Alias,<TAB> -All.

Why? I think it is because the -Type parameter (alias for -CommandType) accepts [System.Management.Automation.CommandTypes] enum flags. I have noticed that all the above success cases are [string[]] parameter.

Actually, my motive in the first place is to fix Trace-Command -Name CmdletProviderClasses,<TAB> -Expression {}. The -Name is also [string[]]. But I mistook the PR could solve more wide range of problems including Get-Command.

Additionally, I just care about the ,<TAB>, not the , <TAB> (comma and space). The , <TAB> completions does not work well with or without this PR. The enum flags case and the , <TAB> case might need more investigation and other PRs.

Based on the above, I would like to propose the following fixes:

• Fix test cases: replace Get-Command with some commands, for example, Get-ChildItem
• Fix PR title represent a smaller problem, for example, "Enable completions for array parameter value just after comma without space even if other parameters follow it"

Yeah that sounds right, it did look like there was some Enum related code when I stepped through it yesterday. The only problem with a partial fix is that it causes the tab completion code to throw when you try with Enums and ideally it would never throw but throwing doesn't cause any issues as far as I know.
I would encourage you to do a full fix for the experience but if not then that's fine as well, I'll probably end up doing it if you won't 😁

it causes the tab completion code to throw when you try with Enums and ideally it would never throw

Thank you for your advice. I have fixed it this time for sur... probably:smile:. Please review the code.

It looks good now. If you want to also fix it with a space between the comma and cursor you can change line 4128 in CompletionCompleters from if (!arg.ParameterContainsArgument && arg.Argument.Extent.StartOffset > token.Extent.StartOffset) to:

if (token.Kind == TokenKind.Parameter
|| (token.Extent.StartOffset > arg.Argument.Extent.StartOffset && token.Extent.EndOffset < arg.Argument.Extent.EndOffset))

This also fixes the scenario where you move the cursor between a parameter with a colon and a current value like: Get-Command -CommandType: <Tab> Alias. If you decide to add this change remember to add tests for it.

Updated @MartinGC94's suggested lines (thanks!) and test cases.

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

This PR has 56 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Label      : Small
Size       : +52 -4
Percentile : 22.4%

Total files changed: 3

Change summary by file extension:
.cs : +5 -4
.ps1 : +47 -0

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

🎉v7.3.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes