Bring back `pwsh.exe` for framework dependent packages to support Start-Job by adityapatwardhan · Pull Request #16535 · PowerShell/PowerShell

adityapatwardhan · 2021-12-01T03:23:44Z

PR Summary

Fix #16537
For a framework dependent package we removed pwsh.exe recently, but we need it for supporting Start-Job. So bring it back.

PR Context

Customers of .NET 6 SDK docker images reported the issue here: dotnet/dotnet-docker#3302

PR Checklist

…-Job

iSazonov · 2021-12-01T03:43:19Z

Will fix #16532?

adityapatwardhan · 2021-12-01T19:23:21Z

Marking it as WIP as I am adding some tests.

tools/releaseBuild/azureDevOps/releasePipeline.yml

TravisEz13

the signing issue is the main thing that needs to be addressed

TravisEz13 · 2021-12-02T19:46:25Z

build.psm1

-        $Arguments += "/property:UseAppHost=false"
+        # The UseAppHost = true property creates ".exe" for the fxdependent packages.
+        # We need this in the package as Start-Job needs it.
+        $Arguments += "/property:UseAppHost=true"


I think we removed this because it was not signed.. we should sign it.

Good point.. let me check the test build.

Updated the packaging code.

adityapatwardhan · 2021-12-02T20:01:35Z

@TravisEz13 I have kicked off a test build with signing to validate the change. I will remove WIP when I have validated it.

pull-request-quantifier-deprecated · 2021-12-02T21:19:06Z

This PR has 89 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Small
Size       : +83 -6
Percentile : 35.6%

Total files changed: 5

Change summary by file extension:
.wxs : +4 -0
.psm1 : +3 -4
.yml : +76 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

adityapatwardhan · 2021-12-02T22:37:41Z

@TravisEz13 validated that the fxdependent package has pwsh.exe which is signed.

cboulva99 · 2021-12-06T09:59:06Z

Hello, Thank you for the fix @adityapatwardhan ,

So, any idea when will this fix make it in the official dotnet6 sdk docker images?

Thank you in advance,

BR

adityapatwardhan · 2021-12-06T22:39:27Z

We are trying to get a fix in for the next release of the images.

ghost · 2021-12-14T18:15:48Z

🎉v7.2.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost · 2021-12-16T19:55:48Z

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…rt-Job (PowerShell#16535) * Bring back pwsh.exe for framework dependent packages to support Start-Job * Update wix file * Add release tests for fxd packages * Fix tests * Fix stage dependencies * Address CR comments * Fix typo * Add value for the hashtable item

Bring back pwsh.exe for framework dependent packages to support Start…

42d5e86

…-Job

adityapatwardhan requested review from PaulHigin, TravisEz13, anmenaga and daxian-dbw as code owners December 1, 2021 03:23

ghost assigned TravisEz13 Dec 1, 2021

pull-request-quantifier-deprecated bot added the Extra Small label Dec 1, 2021

PaulHigin approved these changes Dec 1, 2021

View reviewed changes

adityapatwardhan changed the title ~~Bring back pwsh.exe for framework dependent packages to support Start-Job~~ [WIP] Bring back pwsh.exe for framework dependent packages to support Start-Job Dec 1, 2021

adityapatwardhan added 3 commits December 1, 2021 13:45

Update wix file

99ac966

Add release tests for fxd packages

0952b51

Fix tests

407fa3e

pull-request-quantifier-deprecated bot added Small and removed Extra Small labels Dec 1, 2021

Fix stage dependencies

3c8785a

adityapatwardhan changed the title ~~[WIP] Bring back pwsh.exe for framework dependent packages to support Start-Job~~ Bring back pwsh.exe for framework dependent packages to support Start-Job Dec 1, 2021

adityapatwardhan added the Backport-7.2.x-Consider label Dec 1, 2021

daxian-dbw approved these changes Dec 2, 2021

View reviewed changes

iSazonov mentioned this pull request Dec 2, 2021

Start-Job fails on PowerShell 7.2.0 when installed as a .NET global tool #16537

Closed

5 tasks

TravisEz13 reviewed Dec 2, 2021

View reviewed changes

tools/releaseBuild/azureDevOps/releasePipeline.yml Outdated Show resolved Hide resolved

TravisEz13 requested changes Dec 2, 2021

View reviewed changes

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 2, 2021

Address CR comments

9b23259

adityapatwardhan changed the title ~~Bring back pwsh.exe for framework dependent packages to support Start-Job~~ [WIP] Bring back pwsh.exe for framework dependent packages to support Start-Job Dec 2, 2021

adityapatwardhan added 2 commits December 2, 2021 12:27

Fix typo

c7ca2bc

Add value for the hashtable item

489b8bf

adityapatwardhan changed the title ~~[WIP] Bring back pwsh.exe for framework dependent packages to support Start-Job~~ Bring back pwsh.exe for framework dependent packages to support Start-Job Dec 2, 2021

TravisEz13 approved these changes Dec 2, 2021

View reviewed changes

adityapatwardhan added Backport-7.2.x-Approved and removed Backport-7.2.x-Consider labels Dec 2, 2021

TravisEz13 merged commit 2d27da4 into PowerShell:master Dec 2, 2021

adityapatwardhan deleted the PwshFxd branch December 2, 2021 23:05

anmenaga added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.2.x-Done labels Dec 8, 2021

ajansveld mentioned this pull request Dec 15, 2021

7.2.0 win-fxdependent release packages do not include pwsh.exe #16448

Closed

5 tasks

TravisEz13 removed the Backport-7.2.x-Approved label Mar 11, 2022

TravisEz13 mentioned this pull request May 24, 2022

Update TLS test based on current platform settings #17424

Merged

TravisEz13 mentioned this pull request Jun 7, 2022

Backport test fixes for 7.2 #17494

Merged

22 tasks

TravisEz13 mentioned this pull request Apr 16, 2024

WIP: add more detail to suspicious scriptblock logging #21475

Closed

TravisEz13 mentioned this pull request Jul 9, 2024

Add script to update SDK for release branches #24034

Merged

Conversation

adityapatwardhan commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

iSazonov commented Dec 1, 2021

Uh oh!

adityapatwardhan commented Dec 1, 2021

Uh oh!

Uh oh!

TravisEz13 left a comment

Choose a reason for hiding this comment

Uh oh!

TravisEz13 Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented Dec 2, 2021

Uh oh!

pull-request-quantifier-deprecated bot commented Dec 2, 2021

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

adityapatwardhan commented Dec 2, 2021

Uh oh!

cboulva99 commented Dec 6, 2021

Uh oh!

adityapatwardhan commented Dec 6, 2021

Uh oh!

ghost commented Dec 14, 2021

Uh oh!

ghost commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

adityapatwardhan commented Dec 1, 2021 •

edited

Loading