Skip to content

Add right-click menu to Run with PowerShell for ps1 scripts#12970

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
machv:msi-run-with-pwsh
Jun 30, 2020
Merged

Add right-click menu to Run with PowerShell for ps1 scripts#12970
TravisEz13 merged 1 commit intoPowerShell:masterfrom
machv:msi-run-with-pwsh

Conversation

@machv
Copy link
Copy Markdown
Contributor

@machv machv commented Jun 16, 2020

PR Summary

PR Context

Classic PowerShell has an option in the file context menu to easily run a PowerShell script with just a right-click on the PowerShell file. With this change to the MSI setup, the same option would be provided also for PowerShell Core installations when installed using the MSI installer on Windows.

By default this option is not enabled, user can select this during interactive setup:
image

Or using a property (ADD_EXPLORER_CONTEXT_MENU_OPENPOWERSHELL=1) in case of unattended installation.

This option would be then added in the right-click context menu for .ps1 files:
image

PR Checklist

@ghost ghost assigned iSazonov Jun 16, 2020
@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 16, 2020
@iSazonov iSazonov requested a review from TravisEz13 June 16, 2020 10:35
@iSazonov
Copy link
Copy Markdown
Collaborator

@heaths Could you please review the PR?

@iSazonov iSazonov requested a review from SteveL-MSFT June 16, 2020 10:35
@TravisEz13 TravisEz13 added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 16, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 17, 2020
@iSazonov
Copy link
Copy Markdown
Collaborator

@machv Please rebase and update Files.wxs because we moved to new .Net 5 Preview version.

…in MSI setup.

Refactor registry WiX configuration for right-click menu.
@machv machv force-pushed the msi-run-with-pwsh branch from 16aa665 to 5ace9d9 Compare June 23, 2020 09:49
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 30, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jun 30, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Copy Markdown
Collaborator

@TravisEz13 Could you please review the PR? Can we merge?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 30, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.6 milestone Jun 30, 2020
@TravisEz13 TravisEz13 changed the title Add right-click context menu option to Run with PowerShell Core for ps1 scripts Add right-click menu to Run with PowerShell for ps1 scripts Jun 30, 2020
@TravisEz13 TravisEz13 merged commit 9a29cb5 into PowerShell:master Jun 30, 2020
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jul 1, 2020

@machv Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants