Enable Ctrl+C to work for global tool#11959
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Feb 26, 2020
Merged
Conversation
Member
|
@adityapatwardhan A question: pwsh can still receive |
Member
Author
|
@daxian-dbw Yes, pwsh still receives the |
TravisEz13
approved these changes
Feb 26, 2020
Ctlr C in the global tool shimCtrl+C to work for global tool
|
Thanks! |
|
🎉 Handy links: |
This was referenced Mar 5, 2020
|
Dropping this here to let people know this might've also fixed microsoft/vscode#86459 & microsoft/terminal#1894 |
silijon
pushed a commit
to SkyKick/PowerShell
that referenced
this pull request
Jul 2, 2020
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11314
PR Summary
Global tool shim layer should not handle Ctlr+C as it does compete with the launched global tool and makes the usage of console impossible.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.