V2ServerAPICalls: fix unnecessary and in FindVersionGlobbing w/ Artifactory#1644
Merged
alerickson merged 1 commit intoPowerShell:masterfrom May 7, 2024
Conversation
Closed
3 tasks
anamnavi
approved these changes
Apr 29, 2024
Member
anamnavi
left a comment
There was a problem hiding this comment.
LGTM, thanks for putting this in @sean-r-williams
Member
|
/azp run PowerShell.PSResourceGet |
|
Azure Pipelines successfully started running 1 pipeline(s). |
14 tasks
Contributor
Author
|
@alerickson I see the Backport-1.0.x-consider flag was added - what would it take to get this included in 1.0.5? (Is there any indication on the lead-time for other bugfixes included in the next 1.0.x patch?) |
Collaborator
|
@sean-r-williams we are hoping to release soon and plan to include this... we release as needed not on a particular cadence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes a bug in
V2ServerAPICalls.FindVersionGlobbing()wherein anandwas being emitted unnecessarily.Fixes #1633.
PR Context
FindVersionGlobbing()currently builds query filters by repeatedly appending filter clauses to the URL. Most NuGet v2 server types expectIdto be provided in the$filterparameter, however Artifactory does not. As a result, thefilterQuerystring is still null at line 1153 and prepending anandyields an invalid filter.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.