Skip to content

Add 10 minute timeout to HTTPClient#1626

Merged
alerickson merged 4 commits intoPowerShell:masterfrom
alerickson:upTimeout
Apr 29, 2024
Merged

Add 10 minute timeout to HTTPClient#1626
alerickson merged 4 commits intoPowerShell:masterfrom
alerickson:upTimeout

Conversation

@alerickson
Copy link
Member

PR Summary

Add a 10 minute timeout to HTTPClient.
Remove duplicate HttpClient object in ContainerRegistryServerAPICalls class.

PR Context

Resolves #1060

PR Checklist

Copy link
Member

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alerickson alerickson merged commit 3cf77c2 into PowerShell:master Apr 29, 2024
@alerickson alerickson deleted the upTimeout branch April 29, 2024 18:34
@SydneyhSmith
Copy link
Collaborator

@alerickson will cherry pick change to exclude the container registry change for the 1.0.5 release

@GuillaumeBau
Copy link

GuillaumeBau commented May 28, 2024

Hello,
This PR break the #1599
In src/code/V2ServerAPICalls.cs line 78, the added line " _sessionClient = new HttpClient(handler);" break the code because #1599 already create the HttpClient line 45 and 51.
It's the same in src/code/V3ServerAPICalls.cs line 78.

I try to use a PAT token but it's not works like #1599.

@anamnavi or @alerickson, Can you confirm it ?

Thanks

@GuillaumeBau
Copy link

I have tried it on my local environment and I confirm that is correct (
although there was no doubt).

Using a PAT works again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update-PSResource timeout

4 participants