Skip to content

Attempt fix save script without -includexml (#1609)#1614

Merged
alerickson merged 3 commits intoPowerShell:masterfrom
o-l-a-v:attempt-fix-save-script-without-includexml
Apr 12, 2024
Merged

Attempt fix save script without -includexml (#1609)#1614
alerickson merged 3 commits intoPowerShell:masterfrom
o-l-a-v:attempt-fix-save-script-without-includexml

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Mar 31, 2024

PR Summary

Attempt fix to save script without -includexml, #1609.

Fixes #1609

Test added in PR #1613.

PR Context

PR Checklist

@SydneyhSmith
Copy link
Collaborator

Thanks so much @o-l-a-v could you please add the tests to this PR so they can all be tested together before merge...thanks!

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Apr 6, 2024

@SydneyhSmith Done. :)

Copy link
Member

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this fix in @o-l-a-v we appreciate it :)

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Apr 10, 2024

I made the requested changes @anamnavi.

@anamnavi
Copy link
Member

Had to approve the workflow to start tests running, once they pass I'll merge it in :)

@adityapatwardhan
Copy link
Member

/azp run PowerShell.PSResourceGet

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save-PSResource script fails

5 participants