Ensure that exception is not swallowed by finally block#1569
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Feb 21, 2024
Merged
Ensure that exception is not swallowed by finally block#1569adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
alerickson
approved these changes
Feb 16, 2024
anamnavi
requested changes
Feb 16, 2024
alerickson
pushed a commit
to alerickson/PSResourceGet
that referenced
this pull request
Apr 1, 2024
alerickson
pushed a commit
to alerickson/PSResourceGet
that referenced
this pull request
Apr 2, 2024
alerickson
pushed a commit
that referenced
this pull request
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Some cases the exception was not caught but swallowed by finally block.
Ensure we rethrow the exception after writing error.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.