Skip to content

Conversation

@taomaree
Copy link

@taomaree taomaree commented Oct 2, 2024

What is the purpose of the change

分布式环境、容器环境、研发测试环境,很难做到每台服务器时间是100%同步的,当客户端时间远远大于服务器时间时,不管客户端是不是存在,会导致服务端判断客户端的心跳一直存在。最好是基于服务端本身的时间来做判断,这样判断更精确一些。
我们基于此逻辑修改后,已用于生产部署,目前运行一切正常。

Brief changelog

It is best to associate an existing issue

Verifying this change

Do I need to test?
Has testing been completed?
Test method?

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 3 checklist before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Follow the git commit specification
    • feat: xxx -> The feat type is used to identify production changes related to new backward-compatible abilities or functionality.
    • perf: xxx -> The perf type is used to identify production changes related to backward-compatible performance improvements.
    • fix: xxx -> The fix type is used to identify production changes related to backward-compatible bug fixes.
    • docs: xxx -> The docs type is used to identify documentation changes related to the project - whether intended externally for the end users (in case of a library) or internally for the developers.
    • test: xxx -> The test type is used to identify development changes related to tests - such as refactoring existing tests or adding new tests.
    • refactor: xxx -> The refactor type is used to identify development changes related to modifying the codebase, which neither adds a feature nor fixes a bug - such as removing redundant code, simplifying the code, renaming variables, etc.

KFCFans added a commit that referenced this pull request Aug 17, 2025
@KFCFans
Copy link
Member

KFCFans commented Aug 17, 2025

感谢你的贡献~
由于主干有冲突,pr 没办法直接合进去。后续会在 release 提及该 pr 哈~

@KFCFans KFCFans closed this Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants