Merged
Conversation
marandaneto
approved these changes
Apr 9, 2024
Member
marandaneto
left a comment
There was a problem hiding this comment.
Nice debugging and a very detailed PR desc.
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Apr 9, 2024
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Apr 9, 2024
eoghanmurray
added a commit
to daibhin/rrweb
that referenced
this pull request
Apr 9, 2024
eoghanmurray
added a commit
to rrweb-io/rrweb
that referenced
this pull request
Apr 18, 2024
* better splitting of selectors - overlapping with #1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
This was referenced Apr 22, 2024
Merged
jaj1014
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Apr 30, 2024
* better splitting of selectors - overlapping with rrweb-io#1401 * Add test from example at PostHog/posthog#21427 * ignore brackets inside selector strings * Add another test as noticed that it's possible to escape strings * Ensure we are ignoring commas within strings Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ticket https://posthoghelp.zendesk.com/agent/tickets/11767
Customers website was not rendering correctly due to a CSS rule of the form
The CSS parser included in RRWeb attempts to find the selector for a given rule. It uses these selectors to generate hover classes necessary during playback.
However the parser was misinterpreting the
,in the above rule and splitting it into two separate selectors e.g.body > ul :is(li:not(:first-of-type) a:hoverandli:not(:first-of-type).active a). Both of which were malformed. This broke the rest of the stylesheet and meant that the rules were not being loaded.Changes
The problem arises from the split regex
It does not account for nesting. An arbitrary level of nesting cannot be handled in CSS so I opted to create a new JS function in the parser called
splitRootSelectorsThe customers website playback now looks perfect!
Does this work well for both Cloud and self-hosted?
Yes