What exactly do you mean by "broke rfd on Wayland"? 👀

I mean that Wayland-specific things aren't working. I discovered it specifically because the file chooser window didn't have a parent-child relationship to the application (set_parent stopped working).

I haven't really investigated what other things broke, just noticed that the whole wayland feature was disabled in ashpd and all Wayland dependencies were removed from rfd.

Thanks!

@PolyMeilex Would you be so kind and release 0.15.4 with this fix? I think it's pretty important. Thank you!

Done, should be up. Thanks again 🎉

Could this be made optional with a feature flag in the next minor version bump? It's a bunch of extra dependencies and breaks CI when libwayland-client.so isn't installed.

Could this be made optional with a feature flag in the next minor version bump? It's a bunch of extra dependencies and breaks CI when libwayland-client.so isn't installed.

Came here to say this, dependabot's minor update broke CI due to Wayland dependencies not being installed

Came here to say this, dependabot's minor update broke CI due to Wayland dependencies not being installed

It's actually the previous patch release that broke things. This one reverts it to how it was before.

Perhaps the best way forward is to just enable dynamic linkage via dlopen feature of wayland-rs.

To test that, you can just plop this into your cargo.toml and it should make the dependency optional.

wayland-backend = { version = "0.3.10", features = ["dlopen"]