[pcl_cuda_common] Export the pkgconfig file#5026
Merged
larshg merged 2 commits intoPointCloudLibrary:masterfrom Nov 18, 2021
Merged
[pcl_cuda_common] Export the pkgconfig file#5026larshg merged 2 commits intoPointCloudLibrary:masterfrom
larshg merged 2 commits intoPointCloudLibrary:masterfrom
Conversation
mvieth
reviewed
Nov 11, 2021
Member
mvieth
left a comment
There was a problem hiding this comment.
Thank you very much for your pull request. I have added some minor suggestions, inspired by the way PCL_MAKE_PKGCONFIG is used in other PCL modules
larshg
approved these changes
Nov 18, 2021
mvieth
pushed a commit
to mvieth/pcl
that referenced
this pull request
Dec 27, 2021
* [pcl_cuda_common] Export the pkgconfig file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other
pcl_cudacomponents depend onpcl_cuda_common, export it to correctly use the pkgconfig files of thepcl_cuda_*pkgconfigs.Fixes #5025.